Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configs - Cleanup for hemtt macro padding check #1624

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Conversation

PabstMirror
Copy link
Contributor

@PabstMirror PabstMirror commented Oct 28, 2023

not touching flexi-menu

@@ -1,3 +1,6 @@
#pragma hemtt suppress pw3_padded_arg file
#pragma hemtt suppress pw3_padded_arg config

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BrettMayson - still getting with either/both line, not sure if error or just how the includes work

[PW3] Warning: padding a macro argument
     ╭─[/a3/ui_f/hpp/defineDIKCodes.inc:119:36]
     │
 119 │ #define DIK_NUMPADENTER     0x9C    /* Enter on numeric keypad */
     │                                    ┬
     │                                    ╰── padding a macro argument is likely unintended

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's might be where DIK_NUMPADENTER is being used, and the error is just pointing to the wrong location. The comment will be removed, but the padded whitespace won't

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, it's on use not on define
which is actually good because it means we don't have to touch the bi files
a nice-to-have would be to indicate usage location

@PabstMirror PabstMirror marked this pull request as ready for review October 29, 2023 00:13
@PabstMirror PabstMirror added this to the 3.16.2 milestone Oct 29, 2023
@PabstMirror
Copy link
Contributor Author

Building with no warnings for hemtt 1.10
Will pass CI on merge due to changes to make.py

@PabstMirror PabstMirror merged commit 34fc6dc into master Nov 2, 2023
3 of 4 checks passed
@PabstMirror PabstMirror deleted the hemttPadding branch November 2, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants